Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow google-chrome access to the custom flags files in ~/.config. #3418

Merged
merged 4 commits into from
May 16, 2020
Merged

Allow google-chrome access to the custom flags files in ~/.config. #3418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
985689d
Allow google-chrome access to the custom flags files in ~/.config.
mace015 May 15, 2020
69ab58c
Added noblacklist for the custom flag files for google-chrome-stable.
mace015 May 15, 2020
bf5265b
Allow read access to the custom flag files for both google-chrome-bet…
mace015 May 15, 2020
e1a413d
Added the custom flag files for google-chrome stable, beta and unstab…
mace015 May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions etc/inc/disable-programs.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,12 @@ blacklist ${HOME}/.config/cantata
blacklist ${HOME}/.config/catfish
blacklist ${HOME}/.config/celluloid
blacklist ${HOME}/.config/cherrytree
blacklist ${HOME}/.config/chrome-flags.conf
blacklist ${HOME}/.config/chrome-flags.config
blacklist ${HOME}/.config/chrome-beta-flags.conf
blacklist ${HOME}/.config/chrome-beta-flags.config
blacklist ${HOME}/.config/chrome-unstable-flags.conf
blacklist ${HOME}/.config/chrome-unstable-flags.config
blacklist ${HOME}/.config/chromium
blacklist ${HOME}/.config/chromium-dev
blacklist ${HOME}/.config/chromium-flags.conf
Expand Down
6 changes: 6 additions & 0 deletions etc/profile-a-l/google-chrome-beta.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,16 @@ include globals.local
noblacklist ${HOME}/.cache/google-chrome-beta
noblacklist ${HOME}/.config/google-chrome-beta

noblacklist ${HOME}/.config/chrome-beta-flags.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the file names of the flags configuration cfr. what you used in google-chrome.profile. I'm pretty sure the beta version will otherwise not be able to find those (even when they exist). So just drop the '-beta' part. Same goes for the whitelists and the unstable profile. I'll mark those as well, just so you know where to edit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the profiles as they are now and google-chrome-beta does seem to look for chrome-beta-flags.conf / chrome-beta-flags.config.

noblacklist ${HOME}/.config/chrome-beta-flags.config

mkdir ${HOME}/.cache/google-chrome-beta
mkdir ${HOME}/.config/google-chrome-beta
whitelist ${HOME}/.cache/google-chrome-beta
whitelist ${HOME}/.config/google-chrome-beta

whitelist ${HOME}/.config/chrome-beta-flags.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the profiles as they are now and google-chrome-beta does seem to look for chrome-beta-flags.conf / chrome-beta-flags.config.

whitelist ${HOME}/.config/chrome-beta-flags.config

# Redirect
include chromium-common.profile
6 changes: 6 additions & 0 deletions etc/profile-a-l/google-chrome-unstable.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,16 @@ include globals.local
noblacklist ${HOME}/.cache/google-chrome-unstable
noblacklist ${HOME}/.config/google-chrome-unstable

noblacklist ${HOME}/.config/chrome-unstable-flags.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks as above.

Copy link
Contributor Author

@mace015 mace015 May 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the profiles as they are now and google-chrome-unstable does seem to look for chrome-unstable-flags.conf / chrome-unstable-flags.config.

noblacklist ${HOME}/.config/chrome-unstable-flags.config

mkdir ${HOME}/.cache/google-chrome-unstable
mkdir ${HOME}/.config/google-chrome-unstable
whitelist ${HOME}/.cache/google-chrome-unstable
whitelist ${HOME}/.config/google-chrome-unstable

whitelist ${HOME}/.config/chrome-unstable-flags.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks as above.

Copy link
Contributor Author

@mace015 mace015 May 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the profiles as they are now and google-chrome-unstable does seem to look for chrome-unstable-flags.conf / chrome-unstable-flags.config.

whitelist ${HOME}/.config/chrome-unstable-flags.config

# Redirect
include chromium-common.profile
6 changes: 6 additions & 0 deletions etc/profile-a-l/google-chrome.profile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,16 @@ include globals.local
noblacklist ${HOME}/.cache/google-chrome
noblacklist ${HOME}/.config/google-chrome

noblacklist ${HOME}/.config/chrome-flags.conf
noblacklist ${HOME}/.config/chrome-flags.config

mkdir ${HOME}/.cache/google-chrome
mkdir ${HOME}/.config/google-chrome
whitelist ${HOME}/.cache/google-chrome
whitelist ${HOME}/.config/google-chrome

whitelist ${HOME}/.config/chrome-flags.conf
whitelist ${HOME}/.config/chrome-flags.config

# Redirect
include chromium-common.profile