Add configure options when building rpm #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
approved these changes
May 19, 2020
|
@rusty-snake Just curious, when this PR can be merged into master? Or is there a dev branch that it will be merged into? |
|
@sfc-gh-hyu Looks ready to merge, I'll do so in a moment. We don't have a dev branch, so we just wait a bit to give all collaborators a chance to comment/review PR's. Thanks for the PR and take care! |
sfc-gh-hyu
added a commit
to snowflakedb/firejail
that referenced
this pull request
May 19, 2020
Closed
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Dec 13, 2023
For consistency with mkdeb.sh. Note: The default arguments and support for argument overriding was added to to mkrpm.sh on commit 3d97332 ("Add configure options when building rpm (netblue30#3422)", 2020-05-19). The support for appending arguments was added to mkdeb.sh on commit 9a0fbbd ("mkdeb.sh.in: pass remaining arguments to ./configure", 2022-05-13) / PR netblue30#5154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems configure options are hard-coded when building the RPM. I wish to use different config options with RPM, so I added a third argument to
platform/rpm/mkrpm.sh, which can change the configure options in firejail.spec file.