Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile for twitch,youtube,youtube-music; fix git-cola ,add cola #3577

Merged
merged 7 commits into from
Sep 3, 2020
Merged

Add profile for twitch,youtube,youtube-music; fix git-cola ,add cola #3577

merged 7 commits into from
Sep 3, 2020

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Aug 9, 2020

No description provided.

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 11, 2020

There's currently a ssh-askpass(it's in /usr/share/git-cola/ssh-askpas) failing on a newer git-cola version on Arch how exactly do I fix it? whitelist all git,gitk,git-gui,git-cola related directories in /usr/share/ or get rid of the current whitelists or just add a comment if people wants to use ssh in git?

@rusty-snake
Copy link
Collaborator

how exactly do I fix it?

how exactly is it failing?

whitelist all git,gitk,git-gui,git-cola related directories in /usr/share/

For a git clinet? I'm fine with that.

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 11, 2020 •
edited
Loading

how exactly is it failing?

GitHub is already in my list of known-hosts, I'll comment the read-only similarly but it also needs access to that, any diff viewer,editor, probably some python stuff in /usr/share...

https://imgur.com/ZgfB0iM

If it's okay, I'll add them some time later on this PR, I have some work...

@bbhtt
Copy link
Contributor Author

bbhtt commented Aug 12, 2020 •
edited
Loading

I forgot to sync this branch with upstream master...is the merge conflict gone or do I need to do something?

Added two more profiles, fixed git-cola...

Meld needs access to user dbus, do I add a note? ...Done

ssh-askpass was actually a script, I thought it was an executable...It needs access to /run/user/1000/keyring for ssh and /run/user/1000/gnupg for gpg...pinentry is spawned by gpg; /etc/gcrypt also by gpg; it works now so I have removed the comments from private-bin and private-etc...

One of the YouTube music is packed as an appimage,so no disable-shell...

@bbhtt bbhtt changed the title Add profile for twitch,youtube Add profile for twitch,youtube,youtube-music; fix git-cola Aug 12, 2020
@bbhtt bbhtt requested a review from rusty-snake August 13, 2020 07:45
@bbhtt bbhtt changed the title Add profile for twitch,youtube,youtube-music; fix git-cola Add profile for twitch,youtube,youtube-music; fix git-cola ,add cola Aug 20, 2020
rusty-snake
rusty-snake reviewed Aug 25, 2020
View reviewed changes
etc/inc/disable-programs.inc Show resolved Hide resolved
etc/profile-a-l/git-cola.profile Outdated Show resolved Hide resolved
etc/profile-a-l/git-cola.profile Outdated Show resolved Hide resolved
etc/profile-m-z/twitch.profile Outdated Show resolved Hide resolved
etc/profile-m-z/twitch.profile Outdated Show resolved Hide resolved
etc/profile-m-z/youtube.profile Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 2, 2020

Is this okay or something is needed?

@reinerh
Copy link
Collaborator

reinerh commented Sep 2, 2020

Looks good to me, but please wait for @rusty-snake 's reply. :-)

@rusty-snake
Copy link
Collaborator

rusty-snake commented Sep 2, 2020 •
edited
Loading

Everything fine, expect that I'm unsure if we want GPG/SSH for git-cola by default. We have it enabled in all the others git-clients (git,meld,gitter,github-desktop,gitg).

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 2, 2020 •
edited
Loading

expect that I'm unsure if we want GPG/SSH for git-cola by default

Since emails are getting I follow with git too.

gitg needs fixes too, you can't push changes if remote is over ssh+gpg by default in gitconfig: see error cannot connect to SSH-agent in the menu bar below.

I won't be online for a long time, so want to finish up any changes before merge...

rusty-snake
rusty-snake requested changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@rusty-snake rusty-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sort.py.

etc/profile-a-l/cola.profile Outdated
include globals.local

# Redirect

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 3, 2020

Use sort.py.

Ran it through 3607,3603,3577.

@rusty-snake rusty-snake merged commit fdc265b into netblue30:master Sep 3, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinerh reinerh reinerh left review comments

@rusty-snake rusty-snake rusty-snake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbhtt @rusty-snake @reinerh