Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable-shell.inc: add oksh #3829

Merged
merged 1 commit into from
Dec 16, 2020
Merged

disable-shell.inc: add oksh #3829

merged 1 commit into from
Dec 16, 2020

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Dec 16, 2020

"Portable OpenBSD ksh, based on the Public Domain Korn Shell (pdksh)."

Project page: https://github.com/ibara/oksh

$ pacman -Q oksh
oksh 6.8.1-1
$ pacman -Qlq oksh | grep bin/
/usr/bin/
/usr/bin/oksh

"Portable OpenBSD ksh, based on the Public Domain Korn Shell (pdksh)."

Project page: https://github.com/ibara/oksh

    $ pacman -Q oksh
    oksh 6.8.1-1
    $ pacman -Qlq oksh | grep bin/
    /usr/bin/
    /usr/bin/oksh
@rusty-snake rusty-snake merged commit f837567 into netblue30:master Dec 16, 2020
@rusty-snake
Copy link
Collaborator

Thanks for this contribution!

@kmk3 kmk3 deleted the ds-add-oksh branch December 16, 2020 21:23
@kmk3
Copy link
Collaborator Author

kmk3 commented Dec 17, 2020

Hmm I noticed that GitHub butchered the author name and author date of the
original commit.

@rusty-snake Did you use rebase-merge or something like that? I think I'll
test later what option causes this.

P.S.: It also set the committer name to simply "GitHub". IMO ideally it would
be set to whoever merged it, like in a normal non-fast-forward merge, though
that's secondary.

@rusty-snake
Copy link
Collaborator

Did you use rebase-merge or something like that?

"squash and merge"

@matu3ba matu3ba mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants