-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Librewolf profile and Add Sway profile #4164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some suggestions below.
Should we make sway redirect to i3?
Sway is almost i3 the .config are also same the main diif is wayland and x11 but why need to redirect to i3. I think sway profile will also be cool. if not working then we can redirect to i3 for sure 👍 |
That's the reason. |
@rusty-snake I agree it would make sense to implement sway as a redirect profile. Perhaps the term 'redirect' caused confusion in this context for other posters.
@BL4CKH47H4CK3R I think there's some confusion here. The 'redirect' relates to how we use one main profile for common options that are shared among several applications. It does not impact the way sway will work, it only affects the way we write firejail profiles to avoid doing the same stuff all over again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glitsj16, I know that desktop environment or windows manager doesn't matter when I am using firejail. But I see people are creating profile like for i3 which is redundant so I told. Even archiso
is enough to run firejail 😄
so.. `No its not needed as it reveals lots of important /usr/share folders like /usr/share/fonts which can used for font fingerprinting and OS detection. Like the site or attacker will know that which font you are using. Linux and windows common font are not same so its a problem. Besides there are so many other important folders as I see. Librewolf can launch and work perfectly without this options`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-add include whitelist-usr-share-common.inc
.
Why ? |
TL;DR: It whitelist lots of important The role of |
I agree but how about ? |
(Privacy is out of the scope of firejail, it's for security).
It's not needed because it reveals important folders???!
This does not prevent font fingerprinting. Actually it makes the situation worse. If you
Your OS can be detected anyway.
Masking your fonts still does not make them the same.
yes
no (I'm 90% sure it can not open HTTPS on some system without wusc) |
BTW I don't think |
etc/profile-a-l/librewolf.profile
Outdated
# librewolf requires a shell to launch on Arch. We can possibly remove sh though. | ||
#private-bin bash,dbus-launch,dbus-send,env,librewolf,python*,sh,which | ||
# librewolf requires a shell to launch on Arch. | ||
#private-bin bash,dbus-launch,dbus-send,env,librewolf,sh,which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=librewolf#n325 it's just private-bin librewolf,sh
if anyone want to test ...
This PR has a a merge conflict, please rebase. |
etc/profile-a-l/librewolf.profile
Outdated
# librewolf requires a shell to launch on Arch. We can possibly remove sh though. | ||
# Add the next line to your librewolf.local to enable private-bin. | ||
#private-bin bash,dbus-launch,dbus-send,env,librewolf,python*,sh,which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#private-bin bash,dbus-launch,dbus-send,env,librewolf,python*,sh,which | |
#private-bin bash,dbus-launch,dbus-send,env,librewolf,sh,which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had added before but it can't merge changes
1d8c94c
btw tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a rebase (unlike a merge of master) it should work w/o conflicting. Rebasing and squashing some of the commits makes sense anyway if you look at the history. So if you can do an interactive rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 😃
so.. `No its not needed as it reveals lots of important /usr/share folders like /usr/share/fonts which can used for font fingerprinting and OS detection. Like the site or attacker will know that which font you are using. Linux and windows common font are not same so its a problem. Besides there are so many other important folders as I see. Librewolf can launch and work perfectly without this options`
Co-authored-by: rusty-snake <41237666+rusty-snake@users.noreply.github.com>
merged, thanks! |
Parent is shutting down then including firefox-common-addons.profile
error.log