Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo.profile #4284

Merged
merged 2 commits into from
May 18, 2021
Merged

Add cargo.profile #4284

merged 2 commits into from
May 18, 2021

Conversation

rusty-snake
Copy link
Collaborator

@reinerh here is one 😉 (#4281)

@reinerh
Copy link
Collaborator

reinerh commented May 16, 2021

Just tested your profile with a normal/harmless rust project, and once with the bad POC with malicious macros.
Works fine and it prevented the POC from reading my SSH key. 👍

glitsj16
glitsj16 approved these changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few questions on things I'm not sure off...

@netblue30 netblue30 merged commit 4bb9a0d into netblue30:master May 18, 2021
@netblue30
Copy link
Owner

all in, thanks!

@rusty-snake rusty-snake deleted the add-cargo.profile branch May 18, 2021 14:56
@glitsj16 glitsj16 mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitsj16 glitsj16 glitsj16 approved these changes

@reinerh reinerh reinerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rusty-snake @reinerh @netblue30 @glitsj16