Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appimage.c:
mkdir
,chown
,chmod
calls, last two also pose race condition risk.firejail.h:
ASSERT_PERMS
macrosutil.c:
copy_file
function to takeuid
,gid
, andmode
for new file, usefchown
andfchmod
to prevent race condition when setting owner and permissions.euid_common.h:
egid
when switchingeuid
, so files created as root won't need additionalchown
to change group.euid
/egid
to user - if we continue to run code than intended to run as user with root privileges - this is disaster.fs.c and other:
chown
andchmod
where possible, using functions and macros mentioned above.