Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userDnTemplate Type Mismatch Following Helm Upgrade #436

Closed
devasmith opened this issue Dec 10, 2024 · 2 comments · Fixed by #442
Closed

userDnTemplate Type Mismatch Following Helm Upgrade #436

devasmith opened this issue Dec 10, 2024 · 2 comments · Fixed by #442
Labels
bug Something isn't working

Comments

@devasmith
Copy link
Contributor

devasmith commented Dec 10, 2024

The Helm chart version

netbox@5.0.0-beta.158

Environment Versions

Kubernetes: v1.30.6+rke2r1
Helm: v3.16.3
FluxCD: v2.4.0

Custom chart values

userDnTemplate: uid=%(user)s,cn=users,cn=accounts,dc=foo,dc=bar

Current Behavior & Steps to Reproduce

After upgrading to latest helm release 158 I received the following error:

remoteAuth.ldap.userDnTemplate: Invalid type. Expected null, given: string

I think that these changes are related:

"userDnTemplate": {

AUTH_LDAP_USER_DN_TEMPLATE: {{ default nil .Values.remoteAuth.ldap.userDnTemplate }}

Do we need something like this?

AUTH_LDAP_USER_DN_TEMPLATE: {{ if .Values.remoteAuth.ldap.userDnTemplate }}{{ .Values.remoteAuth.ldap.userDnTemplate }}{{ else }}null{{ end }}

Expected Behavior

I expected the application to accept the provided value for remoteAuth.ldap.userDnTemplate without any errors.

NetBox Logs

No response

@devasmith devasmith added the bug Something isn't working label Dec 10, 2024
@LeoColomb LeoColomb changed the title remoteAuth.ldap.userDnTemplate Type Mismatch Following Helm Upgrade userDnTemplate Type Mismatch Following Helm Upgrade Dec 10, 2024
@LeoColomb
Copy link
Member

Thanks for filing this issue, @devasmith.
Indeed, the JSON schema is incorrect here.
It should be typed of string.

Would you like to open a pull request to fix it?

@devasmith
Copy link
Contributor Author

Hey. I added a PR (#442) now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants