Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default class custom links invisible in dark mode #17186

Closed
llamafilm opened this issue Aug 16, 2024 · 1 comment · Fixed by #17248
Closed

Default class custom links invisible in dark mode #17186

llamafilm opened this issue Aug 16, 2024 · 1 comment · Fixed by #17248
Assignees
@arthanson
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@llamafilm
Copy link
Contributor

Deployment Type

NetBox Enterprise

NetBox Version

v4.0.8

Python Version

3.12

Steps to Reproduce

  1. Create a working custom link
  2. Enable dark mode

Expected Behavior

Button should be visible

Observed Behavior

Button is invisible until you mouse over.
mouseover: Screenshot 2024-08-15 at 10 50 07 PM
regular: Screenshot 2024-08-15 at 10 50 03 PM

A similar bug was fixed in #15616 but for some reason it only fixes non-working links. Working links are still invisible.
@llamafilm llamafilm added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Aug 16, 2024
@arthanson arthanson removed their assignment Aug 16, 2024
@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Aug 16, 2024
@arthanson arthanson self-assigned this Aug 16, 2024
@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 16, 2024
@arthanson
Copy link
Collaborator

Issue is here https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/choices.py#L87 as btn-outline-dark is not visible in dark-mode. However this would require a migration to change the values as the choice is stored in the DB, there are also a lot of references to btn-outline-dark in https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/tables/template_code.py and https://github.com/netbox-community/netbox/blob/develop/netbox/templates/extras/inc/format_toggle.html which should probably be changes to btn-outline-secondary.

@arthanson arthanson mentioned this issue Aug 22, 2024
Merged
@jeremystretch jeremystretch mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthanson arthanson

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

17186 change custom link button color from outline-dark to outline-se… netbox-community/netbox
2 participants
@arthanson @llamafilm