Script overview page does not show the last run/status of script job exection in 4.1.x

[timeu]

Deployment Type

Self-hosted

NetBox Version

v4.1.1

Python Version

3.10

Steps to Reproduce

1. Add a dummy script:

from django.db.models import Count, Q

from dcim.models import Cable
from extras.scripts import Script


class Test(Script):
    class Meta:
        name = f'test'
        description = f'test'

    def test_report(self):
        pass

2. Execute the script
3. Navigate to the script overview

Expected Behavior

Last Run and Status should be displayed corectly (job run date and status)

Observed Behavior

"Last Run" column shows "Never" and status is empty.

I believe the issue is:

The name of the script job is set to empty string here but the view template (https://github.com/netbox-community/netbox/blob/develop/netbox/templates/extras/script_list.html#L53) filters the last job on the scipt name.

[alehaa]

That a Script job doesn't have a name is correct, as its identified by the script instance linked to it.

To fix this issue, I believe JobsMixin.get_latest_jobs() must not use the name as key for the dictionary being generated and also not sort by name. Afterwards it should be sufficient to just get the latest job of the script using last_job=script.get_latest_jobs|first, if needed filtering name='' to allow future extensions.

[timeu]

@alehaa : Sounds right. This will work also with script instances that contain multiple classes which have their own job runs ?