Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handing of "pattern" fields during object creation #8119

Closed
jeremystretch opened this issue Dec 20, 2021 · 1 comment
Closed

Improve handing of "pattern" fields during object creation #8119

jeremystretch opened this issue Dec 20, 2021 · 1 comment
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Improve the handling of fields which return a set of multiple values derived from a given pattern, i.e. ExpandableNameField and ExpandableIPAddressField. These are currently handled explicitly as an anti-pattern e.g. under ComponentCreateView.

I still need to do some research to determine our options, but I wanted to get this initiative documented.

Justification

The way these "expanded" fields are handled currently requires intervention within the view logic, and does not scale well to include additional implementations, such as the expansion of module bay positions under #7844.

@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 20, 2021
@jeremystretch jeremystretch self-assigned this Dec 20, 2021
@jeremystretch
Copy link
Member Author

I ended up refactoring most of the device component creation logic under #7846. This is no longer needed.

@jeremystretch jeremystretch removed the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Dec 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

1 participant