Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17614 Disallow removal of virtual chassis from device if set as master #17731

Merged
merged 3 commits into from
Oct 11, 2024
Merged

17614 Disallow removal of virtual chassis from device if set as master #17731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb2656
17614 Disallow removal of virtual chassis from device if set as master
arthanson Oct 10, 2024
3f50b4f
17614 review changes
arthanson Oct 11, 2024
7f91752
17614 review changes
arthanson Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions netbox/dcim/models/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,13 @@ def clean(self):
'vc_position': _("A device assigned to a virtual chassis must have its position defined.")
})

if hasattr(self, 'vc_master_for') and self.vc_master_for and self.vc_master_for != self.virtual_chassis:
arthanson marked this conversation as resolved.
Show resolved Hide resolved
raise ValidationError({
'virtual_chassis': _('Device cannot be removed from virtual chassis {virtual_chassis} because it is currently designated as its master.').format(
virtual_chassis=self.vc_master_for
)
})

def _instantiate_components(self, queryset, bulk_create=True):
"""
Instantiate components for the device from the specified component templates.
Expand Down