Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: anomaly rate pop down chart seems unaligned #662

Closed
andrewm4894 opened this issue Nov 17, 2022 · 12 comments
Closed

[Bug]: anomaly rate pop down chart seems unaligned #662

andrewm4894 opened this issue Nov 17, 2022 · 12 comments
Assignees
Labels
bug Something isn't working cloud-frontend

Comments

@andrewm4894
Copy link

Bug description

seems like the anomaly rate pop down chart is a bit misaligned for some reason.

image

Expected behavior

should line up

Steps to reproduce

  1. open anomaly rate chart

Screenshots

No response

Error Logs

No response

Desktop

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Browser Version [e.g. 22]

Additional context

No response

@andrewm4894 andrewm4894 added bug Something isn't working needs triage labels Nov 17, 2022
@andrewm4894
Copy link
Author

also unsure if its respecting the new filtering options from within the chart.

@hugovalente-pm
Copy link
Contributor

hugovalente-pm commented Nov 18, 2022

@andrewm4894 was checking this today and this seems to be fixed, can you confirm from your side?
image

@andrewm4894
Copy link
Author

@hugovalente-pm @novykh it looks to be fixed apart from one last thing being that the new chart level filters dont seem to be reflected in the anomaly rate pop down chart:

image

I can make a new issue for this if we want?

@andrewm4894
Copy link
Author

actually seems like offset bug is not fixed either - just a little tricky to recreate:

2022-11-18.11-35-34.mp4
2022-11-18.11-40-05.mp4

@hugovalente-pm
Copy link
Contributor

seems the change on group by triggers it, thanks for showing a way to reproduce it

@hugovalente-pm
Copy link
Contributor

@hugovalente-pm @novykh it looks to be fixed apart from one last thing being that the new chart level filters dont seem to be reflected in the anomaly rate pop down chart:

great catch @andrewm4894 , yes lets open a separate bug for that

@andrewm4894
Copy link
Author

this is still unfixed

@hugovalente-pm hugovalente-pm assigned jacekkolasa and unassigned novykh Dec 20, 2022
@hugovalente-pm
Copy link
Contributor

@jacekkolasa is looking into this and seems to be caused by the animation when expanding and collapsing the anomaly bit chart
this animation doesn't exist on the Anomalies tab so we could probably remove it if we don't find an easy way around it

chrome_HxU0Hjlstp.mp4

@jacekkolasa
Copy link

jacekkolasa commented Dec 22, 2022

As @hugovalente-pm shown, the easiest way of reproducing the bug was to open anomaly bit twice.
I deployed a fix to PROD which just disables the animation during collapsing/expandind.

We could bring the animation back, too, but it complicates a little bit our Collapsible component, so we decided not to do this atm.

@hugovalente-pm
Copy link
Contributor

thanks for fixing this @jacekkolasa , yes we can look into the animation at a later stage

@andrewm4894
Copy link
Author

@jacekkolasa @hugovalente-pm i am still seeing this - see video here. not sure exactly how to reproduce or anything but have this example we can drill into easy enough

2023-01-24.10-05-45.mp4

@andrewm4894
Copy link
Author

actually disregard - loosk like a different new bug raised here on agent: netdata/netdata#14318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cloud-frontend
Projects
None yet
Development

No branches or pull requests

5 participants