refactor(hook): improve useURLAppLauncher hook #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't request join room api when already in the same room
Cheerego7
approved these changes
Jun 29, 2021
BlackHole1
added a commit
that referenced
this pull request
Jun 29, 2021
don't request join room api when already in the same room
Leooeloel
pushed a commit
that referenced
this pull request
Jun 29, 2021
* feat(main-app): add join room config to URLprotocol. (#756) * fix(url-protocol): launch flat lost params in url protocol when system is macOS and first open (#767) * feat(URLProtocol): listen to ipc event for launch flat app (#768) * refactor(flat-components): forbid to refresh in Login page (#769) * refactor(hook): improve useURLAppLauncher hook (#770) don't request join room api when already in the same room * fix(hook): join room logic error in useURLAppLauncher hook after joining the room by repeatedly calling up Flat through the browser, if exit the room, will automatically join the room again. because we have a problem in the logic of clearing the roomUUID * refactor(hook): improve usePushHistory hook type Co-authored-by: Cheerego7 <48879533+Cheerego7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't request join room api when already in the same room