feat(desktop): support preview file at new window #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
requested review from
Cheerego7 and
Cyberhan123
and removed request for
Cheerego7
Cyberhan123
reviewed
Dec 24, 2021
desktop/renderer-app/src/pages/CloudStoragePage/CloudStorageFilePreview/DynamicPreview.less
Show resolved
Hide resolved
Cyberhan123
reviewed
Dec 24, 2021
Cyberhan123
previously approved these changes
Dec 27, 2021
Cheerego7
previously approved these changes
Dec 27, 2021
BlackHole1
dismissed stale reviews from Cheerego7 and Cyberhan123
via
a9b21a4
Cheerego7
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo video:
1.mp4
No memory leaks