Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): use native audio to test speaker #1765

Merged
merged 1 commit into from
Nov 9, 2022
Merged

fix(electron): use native audio to test speaker #1765

merged 1 commit into from
Nov 9, 2022

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Nov 9, 2022

No description provided.

crimx
crimx requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@crimx crimx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked until the root cause of this issue is found.

@hyrious hyrious marked this pull request as draft November 9, 2022 08:41
@hyrious hyrious marked this pull request as ready for review November 9, 2022 08:50
@crimx crimx merged commit ada1a75 into netless-io:main Nov 9, 2022
@hyrious hyrious deleted the fix-speaker-test-audio branch November 10, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimx crimx crimx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyrious @crimx