fix(classroom): add loading state to cloud record button #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheerego7
approved these changes
Aug 4, 2022
crimx
requested changes
Aug 5, 2022
packages/flat-components/src/components/ClassroomPage/CloudRecordBtn/index.tsx
Show resolved
Hide resolved
hyrious
added a commit
that referenced
this pull request
Aug 24, 2022
Note: cloud recording function is not working now, this commit only tweaks UI
Merged
crimx
pushed a commit
that referenced
this pull request
Aug 24, 2022
* fix(classroom): add loading state to cloud record button (#1628) Note: cloud recording function is not working now, this commit only tweaks UI * fix(whiteboard): typo (this component will be removed entirely in the future) * refactor(whiteboard): add extra insert image option
crimx
pushed a commit
that referenced
this pull request
Aug 24, 2022
* fix(classroom): add loading state to cloud record button (#1628) Note: cloud recording function is not working now, this commit only tweaks UI * fix(whiteboard): typo (this component will be removed entirely in the future) * refactor(whiteboard): add extra insert image option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.