Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(service-providers): upgrade @netless/fastboard #1952

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Jun 15, 2023

  • support dotted option in the pencil panel

Warning: However, this option applies to all tools that draws curves, e.g. line/arrow/rectangle/shapes. Is it wrong to put dotted option in pencil's scope?

Possible changes:

  1. Move that option to other place, not scope to pencil.
  2. Add a hack in Flat which turns off the option when switching to other tools, so that it only affects pencil.

- support dotted option in the pencil panel
@syt-honey syt-honey requested a review from crimx June 15, 2023 08:08
@hyrious hyrious requested a review from Leooeloel June 15, 2023 08:16
@syt-honey syt-honey merged commit ce7f39f into netless-io:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants