-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add zsh autocomplete setup and file permissions instructions to completion:install #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
…o completion:install Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
We decided not to modify file permissions on the user's behalf and instead output the |
Closed
benhancock
commented
Oct 17, 2024
benhancock
commented
Oct 17, 2024
DanielSLew
requested changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few changes that I've requested
tests/integration/commands/completion/completion-install.test.ts
Outdated
Show resolved
Hide resolved
Merge main into oct-16
Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
Merge main into zsh-fix
Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
Merge zsh-fix into oct-16
DanielSLew
requested changes
Oct 25, 2024
tests/integration/commands/completion/completion-install.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
DanielSLew
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes Completions don't work
There are at least two issues that might cause completions to fail after running
completion:install
:chmod +x
with the file path to the completion scriptautoload -U compinit; compinit
to the user’s~/.zshrc
file above the Tabtab config line to load and then runcompinit
This PR addresses both of these issues by:
chmod +x
command with the appropriate file path for the user to copy and run if needed after the installation is complete;autoload -U compinit; compinit
line added to the top of their .zshrc file automatically if not already present.Here's what the
netlify completion:install
output looks like before:Here's what the
netlify completion:install
output looks like after our changes:This PR also creates a new test file for
completion:install
with tests for thecompinit -> ~/.zshrc
functionality.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)