An assortment of Markdown Editor fixes #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Prosemirror to 0.16.0
It also fixes previews of uploaded images in the markdown editor by making
sure the markdown preview renderer always passes image paths through the
getMediafunction.To make this more performant, I added some memoization around media proxy
lookups.
This PR also implements drag and drop image uploads for both the raw and
the rich markdown editor.
Apart from that it changes the behavior of lists in ProseMirror. By default
lists always gets a
inserted within each
lists "tight" which means they no longer gets
s inserted in the serialized
output.