fix: skip is-crawlable audit when running onSuccess against DEPLOY_URL #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
commented
Oct 21, 2024
| const settings = mergeSettingsSources(inputSettings); | ||
| if (Object.keys(settings).length === 0) return; |
There was a problem hiding this comment.
Now we always pass back the default config, which is the same as if no config is passed to lighthouse at all
cmparsons
approved these changes
Oct 21, 2024
aitchiss
deleted the
suzanne/wrfl-1813-lighthouse-plugin-skip-the-crawlers-audit-when-auditing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run onSuccess we use the
DEPLOY_URLi.e. the permalink of the deploy. These deploys havex-robots-tag: noindexconfigured to stop bots from crawling deploy permalinks vs the main production site URL. This means we almost always receive a false positive for the lighthouseis-crawlablerule.This PR skips that particular audit when running against the deploy url.
To test:
You could install the branch version of this plugin on a site and observe the difference in behaviour, but I did prepare an example 😄
This deploy is made with the latest fix - observe that the SEO report does not include any failure for allowing crawling
This deploy was made before the fix - notice that the SEO score is lower, and the crawling rule is highlighted in the report
