Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-adapter): add default config #153

Merged

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jul 31, 2023

Just like we have in @netlify/remix-edge-adapter

CC/ @ascorbic @nickytonline

@MichaelDeBoey MichaelDeBoey requested a review from a team as a code owner July 31, 2023 15:40
@netlify

This comment was marked as outdated.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for remix-edge ready!

Name Link
🔨 Latest commit ee73044
🔍 Latest deploy log https://app.netlify.com/sites/remix-edge/deploys/653bb2b358a53c0008832d0f
😎 Deploy Preview https://deploy-preview-153--remix-edge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

This comment was marked as outdated.

@MichaelDeBoey MichaelDeBoey force-pushed the add-default-config-to-remix-adapter branch 2 times, most recently from c2597c8 to 91720b2 Compare July 31, 2023 15:46
@MichaelDeBoey
Copy link
Contributor Author

@nickytonline Is there something I should still do to get this one merged?

@MichaelDeBoey MichaelDeBoey force-pushed the add-default-config-to-remix-adapter branch 2 times, most recently from e0db1d5 to bce26aa Compare August 22, 2023 14:25
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for remix-serverless ready!

Name Link
🔨 Latest commit ee73044
🔍 Latest deploy log https://app.netlify.com/sites/remix-serverless/deploys/653bb2b366caf00008743867
😎 Deploy Preview https://deploy-preview-153--remix-serverless.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ascorbic
ascorbic previously approved these changes Oct 27, 2023
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've updated this for v2

@ascorbic ascorbic force-pushed the add-default-config-to-remix-adapter branch from 2e9ec0e to 7ded32a Compare October 27, 2023 11:17
@pieh pieh enabled auto-merge (squash) October 27, 2023 13:12
@pieh pieh disabled auto-merge October 27, 2023 13:17
@pieh pieh merged commit d3b8075 into netlify:main Oct 27, 2023
11 of 13 checks passed
@MichaelDeBoey MichaelDeBoey deleted the add-default-config-to-remix-adapter branch November 3, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants