-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-adapter): add default config #153
Merged
pieh
merged 1 commit into
netlify:main
from
MichaelDeBoey:add-default-config-to-remix-adapter
Oct 27, 2023
Merged
feat(remix-adapter): add default config #153
pieh
merged 1 commit into
netlify:main
from
MichaelDeBoey:add-default-config-to-remix-adapter
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
MichaelDeBoey
force-pushed
the
add-default-config-to-remix-adapter
branch
2 times, most recently
from
July 31, 2023 15:46
c2597c8
to
91720b2
Compare
@nickytonline Is there something I should still do to get this one merged? |
MichaelDeBoey
force-pushed
the
add-default-config-to-remix-adapter
branch
2 times, most recently
from
August 22, 2023 14:25
e0db1d5
to
bce26aa
Compare
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ascorbic
previously approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've updated this for v2
ascorbic
force-pushed
the
add-default-config-to-remix-adapter
branch
from
October 27, 2023 11:17
2e9ec0e
to
7ded32a
Compare
MichaelDeBoey
force-pushed
the
add-default-config-to-remix-adapter
branch
from
October 27, 2023 12:53
7ded32a
to
ee73044
Compare
ascorbic
approved these changes
Oct 27, 2023
pieh
approved these changes
Oct 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we have in
@netlify/remix-edge-adapter
CC/ @ascorbic @nickytonline