Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-edge-adapter): exclude /.netlify paths from edge function #296

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

ascorbic
Copy link
Contributor

Description

Adds a default exclusion so that edge SSR doesn't run for paths under /.netlify. I'm going to follow up with an option to add custom paths, but that'll need docs so it will come later.

@ascorbic ascorbic requested a review from a team as a code owner April 19, 2024 16:44
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for remix-serverless ready!

Name Link
🔨 Latest commit d63a4c0
🔍 Latest deploy log https://app.netlify.com/sites/remix-serverless/deploys/66229f7ee30cf700075bdaa8
😎 Deploy Preview https://deploy-preview-296--remix-serverless.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for remix-edge ready!

Name Link
🔨 Latest commit d63a4c0
🔍 Latest deploy log https://app.netlify.com/sites/remix-edge/deploys/66229f7ee30cf700075bdaac
😎 Deploy Preview https://deploy-preview-296--remix-edge.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ascorbic ascorbic merged commit 09bf62b into main Apr 20, 2024
22 checks passed
@ascorbic ascorbic deleted the exclude-netlify branch April 20, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants