Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

feat: add runtime API version property #1575

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

jenae-janzen
Copy link
Contributor

@jenae-janzen jenae-janzen commented Sep 25, 2023

🎉 Thanks for submitting a pull request! 🎉
Adds a property to surface the runtime API version for the function in build data. Part of issue https://linear.app/netlify/issue/COM-6/expose-the-ability-to-query-for-functions-using-the-v2-api

We added this to an object called build data to distinguish it from info about the function runtime and to allow us to add more properties about the build in the future.

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻.
    This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
    a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@jenae-janzen jenae-janzen requested a review from a team as a code owner September 25, 2023 13:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

⏱ Benchmark results

Comparing with 11d452b

largeDepsEsbuild: 3.2s

⬆️ 21.79% increase vs. 11d452b

^                                                           3.7s                                          
│                                                           ┌──┐                                          
│                                                           |  |                                          
│           3.2s                                    3.1s    |  |            3.1s                    3.2s  
│           ┌──┐                                    ┌──┐    |  |            ┌──┐                    ┌──┐  
│ ──2.7s────┼──┼────────────2.8s────────────────────┼──┼────┼──┼────────────┼──┼────────────────────|▒▒|──
│   ┌──┐    |  |    2.5s    ┌──┐    2.6s            |  |    |  |    2.6s    |  |    2.6s    2.5s    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    ┌──┐    2.4s    |  |    |  |    ┌──┐    |  |    ┌──┐    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 9.7s

⬆️ 22.76% increase vs. 11d452b

^                                                          11.7s                                          
│                                                           ┌──┐                                          
│                                                           |  |                                          
│           9.9s                                    9.8s    |  |            9.7s                    9.7s  
│           ┌──┐                                    ┌──┐    |  |            ┌──┐                    ┌──┐  
│           |  |            8.5s                    |  |    |  |            |  |                    |▒▒|  
│ ──8.2s────┼──┼────────────┌──┐────────────────────┼──┼────┼──┼────8.2s────┼──┼────────────────────|▒▒|──
│   ┌──┐    |  |    7.5s    |  |    7.8s    7.5s    |  |    |  |    ┌──┐    |  |    7.9s    7.5s    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 18.6s

⬆️ 22.36% increase vs. 11d452b

^                                                          22.3s                                          
│                                                           ┌──┐                                          
│                                                           |  |                                          
│          19.3s                                   19.3s    |  |                                   18.6s  
│           ┌──┐                                    ┌──┐    |  |           18.3s                    ┌──┐  
│           |  |                                    |  |    |  |            ┌──┐                    |▒▒|  
│ ─15.8s────┼──┼───────────16.1s────────────────────┼──┼────┼──┼───15.4s────┼──┼───15.2s────────────|▒▒|──
│   ┌──┐    |  |    15s     ┌──┐   14.6s   14.9s    |  |    |  |    ┌──┐    |  |    ┌──┐   14.4s    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    ┌──┐    ┌──┐    |  |    |  |    |  |    |  |    |  |    ┌──┐    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@jenae-janzen jenae-janzen enabled auto-merge (squash) September 25, 2023 13:35
@jenae-janzen jenae-janzen merged commit 8d205ca into main Sep 25, 2023
@jenae-janzen jenae-janzen deleted the add-build-data-to-function-manifest branch September 25, 2023 13:40
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
* feat: add runtime API version property

* fix: remove only from test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants