This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: infer TS module format from package.json
#1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 7aeed4d largeDepsEsbuild: 3.2s⬆️ 7.19% increase vs. 7aeed4d Legend
largeDepsNft: 9.3s⬇️ 0.92% decrease vs. 7aeed4d Legend
largeDepsZisi: 18.3s⬆️ 1.77% increase vs. 7aeed4d Legend
|
lukasholzer
previously approved these changes
Oct 2, 2023
Comment on lines
89
to
90
| // Returns the module format that should be used when transpiling a TypeScript | ||
| // file. |
There was a problem hiding this comment.
NIT: comments for functions/methods or variables should always be JSDoc as the IntelliSense can pick them up. A regular code block comment should be just used inside functions as it is not part of the AST
Suggested change
| // Returns the module format that should be used when transpiling a TypeScript | |
| // file. | |
| /** | |
| * Returns the module format that should be used when transpiling a TypeScript | |
| * file. | |
| */ |
src/runtimes/node/utils/tsconfig.ts
Outdated
Comment on lines
9
to
11
| // Looks for a `tsconfig.json` file on a given path and, if one exists, returns | ||
| // the module format inferred from the `module` property. If no file is found | ||
| // or if no `module` property is defined, the function returns `undefined`. |
There was a problem hiding this comment.
Suggested change
| // Looks for a `tsconfig.json` file on a given path and, if one exists, returns | |
| // the module format inferred from the `module` property. If no file is found | |
| // or if no `module` property is defined, the function returns `undefined`. | |
| /** | |
| * Looks for a `tsconfig.json` file on a given path and, if one exists, returns | |
| * the module format inferred from the `module` property. If no file is found | |
| * or if no `module` property is defined, the function returns `undefined`. | |
| */ |
Same here
lukasholzer
approved these changes
Oct 2, 2023
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…hip-it#1580) * fix: infer TS module format from `package.json` * chore: typo * chore: update comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we're only looking at
tsconfig.jsonto infer the module type. We need to also look atpackage.jsonas a fallback.