fix: output `provided.al2` also when zipGo is disabled #1609

Skn0tt · 2023-10-11T12:29:30Z

We were only emitting runtimeVersion: "provided.al2" when zipGo is enabled. In Buildbot deploys, this is disabled, so we weren't emitting provided.al2 properly! This PR fixes that.

I also noticed we weren't emitting generator and runtimeVersion when zipGo is enabled. I don't think that's intended, so I changed it as well.

github-actions · 2023-10-11T12:32:21Z

⏱ Benchmark results

Comparing with fffff21

largeDepsEsbuild: 3.5s

⬆️ 23.82% increase vs. fffff21

^           3.6s                                            3.6s                                    3.5s  
│           ┌──┐            3.4s                            ┌──┐                                    ┌──┐  
│           |  |    3.2s    ┌──┐            3.2s            |  |    3.2s                            |▒▒|  
│           |  |    ┌──┐    |  |            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┼──┼────┼──┼────2.8s────┼──┼────────────┼──┼────┼──┼────2.8s────────────────────|▒▒|──
│           |  |    |  |    |  |    ┌──┐    |  |    2.7s    |  |    |  |    ┌──┐    2.7s    2.7s    |▒▒|  
│   2.5s    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    ┌──┐    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (60d1ecb): 2.8s
T-29 (4778ed7): 2.8s
T-28 (f5529d7): 2.8s
T-27 (d98dd20): 2.6s
T-26 (6be379e): 2.7s
T-25 (ad2c55d): 2.8s
T-24 (304f7f5): 2.6s
T-23 (45ebfea): 3.1s
T-22 (2070b46): 3.7s
T-21 (5d277e7): 2.7s
T-20 (360f373): 2.4s
T-19 (5c6c14a): 2.7s
T-18 (1ea5222): 2.6s
T-17 (4e2fe8b): 3s
T-16 (25c1ae4): 2.6s
T-15 (90325b2): 2.7s
T-14 (1eccedc): 2.8s
T-13 (c9e5384): 2.6s
T-12 (b40788a): 2.5s
T-11 (6ff4fbe): 3.6s
T-10 (dfe6dd0): 3.2s
T-9 (6b85304): 3.4s
T-8 (cd48552): 2.8s
T-7 (cf77a72): 3.2s
T-6 (722a724): 2.7s
T-5 (9e3af6a): 3.6s
T-4 (7eb97de): 3.2s
T-3 (6be8b42): 2.8s
T-2 (23405c6): 2.7s
T-1 (fffff21): 2.7s
T (current commit): 3.5s

largeDepsNft: 11.1s

⬆️ 24.36% increase vs. fffff21

^          11.8s                                           11.6s                                          
│           ┌──┐                                            ┌──┐                                   11.1s  
│           |  |           10.5s                            |  |                                    ┌──┐  
│           |  |            ┌──┐           10.2s            |  |    9.8s                            |▒▒|  
│           |  |    9.4s    |  |            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┌──┐────┼──┼────8.5s────┼──┼────────────┼──┼────┼──┼────8.7s────────────────────|▒▒|──
│           |  |    |  |    |  |    ┌──┐    |  |    8.3s    |  |    |  |    ┌──┐    8.5s    8.4s    |▒▒|  
│   7.8s    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    ┌──┐    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (60d1ecb): 8.2s
T-29 (4778ed7): 8.3s
T-28 (f5529d7): 8.7s
T-27 (d98dd20): 7.6s
T-26 (6be379e): 8.5s
T-25 (ad2c55d): 8.3s
T-24 (304f7f5): 8.1s
T-23 (45ebfea): 10.1s
T-22 (2070b46): 12.1s
T-21 (5d277e7): 8.3s
T-20 (360f373): 7.5s
T-19 (5c6c14a): 8s
T-18 (1ea5222): 7.7s
T-17 (4e2fe8b): 9.3s
T-16 (25c1ae4): 7.9s
T-15 (90325b2): 8.4s
T-14 (1eccedc): 8.4s
T-13 (c9e5384): 8.3s
T-12 (b40788a): 7.8s
T-11 (6ff4fbe): 11.8s
T-10 (dfe6dd0): 9.4s
T-9 (6b85304): 10.5s
T-8 (cd48552): 8.5s
T-7 (cf77a72): 10.2s
T-6 (722a724): 8.3s
T-5 (9e3af6a): 11.6s
T-4 (7eb97de): 9.8s
T-3 (6be8b42): 8.7s
T-2 (23405c6): 8.5s
T-1 (fffff21): 8.4s
T (current commit): 11.1s

largeDepsZisi: 20.8s

⬆️ 20.56% increase vs. fffff21

^          21.9s                                           21.8s                                          
│           ┌──┐                                            ┌──┐                                   20.8s  
│           |  |           20.3s           19.9s            |  |   19.4s                            ┌──┐  
│           |  |   18.3s    ┌──┐            ┌──┐            |  |    ┌──┐                            |▒▒|  
│ ──────────┼──┼────┌──┐────┼──┼────────────┼──┼────────────┼──┼────┼──┼────────────────────────────|▒▒|──
│           |  |    |  |    |  |   16.4s    |  |   16.2s    |  |    |  |   16.8s   16.2s   16.5s    |▒▒|  
│           |  |    |  |    |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    ┌──┐    ┌──┐    ┌──┐    |▒▒|  
│  14.8s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (60d1ecb): 15.8s
T-29 (4778ed7): 16.1s
T-28 (f5529d7): 16.4s
T-27 (d98dd20): 14.8s
T-26 (6be379e): 16.1s
T-25 (ad2c55d): 15.9s
T-24 (304f7f5): 15.5s
T-23 (45ebfea): 19.3s
T-22 (2070b46): 22.4s
T-21 (5d277e7): 15.7s
T-20 (360f373): 14.4s
T-19 (5c6c14a): 15.7s
T-18 (1ea5222): 15.1s
T-17 (4e2fe8b): 17.9s
T-16 (25c1ae4): 15.4s
T-15 (90325b2): 16.3s
T-14 (1eccedc): 15.9s
T-13 (c9e5384): 15.7s
T-12 (b40788a): 14.8s
T-11 (6ff4fbe): 21.9s
T-10 (dfe6dd0): 18.3s
T-9 (6b85304): 20.3s
T-8 (cd48552): 16.4s
T-7 (cf77a72): 19.9s
T-6 (722a724): 16.2s
T-5 (9e3af6a): 21.8s
T-4 (7eb97de): 19.4s
T-3 (6be8b42): 16.8s
T-2 (23405c6): 16.2s
T-1 (fffff21): 16.5s
T (current commit): 20.8s

…t-and-ship-it#1609) * fix: also emit `provided.al2` when zipGo is disabled * fix: emit generator and runtimeVersion in zipGo path --------- Co-authored-by: Lukas Holzer <lukas.holzer@netlify.com>

Skn0tt added 2 commits October 11, 2023 14:26

fix: also emit provided.al2 when zipGo is disabled

e301830

fix: emit generator and runtimeVersion in zipGo path

a75a2dc

Skn0tt requested a review from a team as a code owner October 11, 2023 12:29

Skn0tt self-assigned this Oct 11, 2023

Skn0tt mentioned this pull request Oct 11, 2023

feat: upload go binaries as al2-compatible zip netlify/open-api#490

Merged

lukasholzer approved these changes Oct 11, 2023

View reviewed changes

Merge branch 'main' into al2-buildbot-mode

60ded80

lukasholzer enabled auto-merge (squash) October 11, 2023 14:24

lukasholzer merged commit d1a18f1 into main Oct 11, 2023

lukasholzer deleted the al2-buildbot-mode branch October 11, 2023 14:29

token-generator-app bot mentioned this pull request Oct 11, 2023

chore(main): release 9.24.2 #1611

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: output `provided.al2` also when zipGo is disabled #1609

fix: output `provided.al2` also when zipGo is disabled #1609

Skn0tt commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023 •

edited

Loading

fix: output provided.al2 also when zipGo is disabled #1609

fix: output provided.al2 also when zipGo is disabled #1609

Conversation

Skn0tt commented Oct 11, 2023 • edited Loading

github-actions bot commented Oct 11, 2023 • edited Loading

⏱ Benchmark results

largeDepsEsbuild: 3.5s

largeDepsNft: 11.1s

largeDepsZisi: 20.8s

fix: output `provided.al2` also when zipGo is disabled #1609

fix: output `provided.al2` also when zipGo is disabled #1609

Skn0tt commented Oct 11, 2023 •

edited

Loading

github-actions bot commented Oct 11, 2023 •

edited

Loading