fix: populate Netlify global before customer code #1643

Skn0tt · 2023-11-02T16:32:07Z

Fixes https://linear.app/netlify/issue/COM-101/unable-to-use-netlifyenv-in-functions-v2.

tests/v2api.test.ts

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

github-actions · 2023-11-02T16:34:48Z

⏱ Benchmark results

Comparing with a01ecdb

largeDepsEsbuild: 2.7s

⬇️ 16.06% decrease vs. a01ecdb

^   3.3s                                            3.4s                                                  
│   ┌──┐    3.3s            3.2s            3.1s    ┌──┐                                    3.1s          
│   |  |    ┌──┐            ┌──┐            ┌──┐    |  |            3.1s                    ┌──┐          
│   |  |    |  |            |  |            |  |    |  |            ┌──┐                    |  |          
│ ──┼──┼────┼──┼────2.7s────┼──┼────────────┼──┼────┼──┼────────────┼──┼────2.7s────────────┼──┼────2.7s──
│   |  |    |  |    ┌──┐    |  |    2.5s    |  |    |  |    2.6s    |  |    ┌──┐    2.5s    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (9f3dab8): 3.3s
T-29 (bf7a4ac): 2.7s
T-28 (cc8ad7c): 3.8s
T-27 (58c8344): 3.3s
T-26 (9efef2f): 2.8s
T-25 (84ff0f8): 2.5s
T-24 (7eafe95): 2.5s
T-23 (57c38e3): 3.2s
T-22 (7898a4b): 3.5s
T-21 (d15abd9): 3.5s
T-20 (efa8ddc): 2.6s
T-19 (600dbf7): 3.1s
T-18 (6051e01): 3s
T-17 (57d30ec): 3s
T-16 (28b658a): 3.2s
T-15 (d7a0d50): 3.5s
T-14 (1618df8): 3.1s
T-13 (0297aa1): 2.7s
T-12 (3092e01): 3.3s
T-11 (cb23207): 3.3s
T-10 (070a7c9): 2.7s
T-9 (37bea38): 3.2s
T-8 (4b0f947): 2.5s
T-7 (a7b9972): 3.1s
T-6 (0381be5): 3.4s
T-5 (af0e46c): 2.6s
T-4 (b7fc082): 3.1s
T-3 (afaa4ef): 2.7s
T-2 (390820e): 2.5s
T-1 (a01ecdb): 3.1s
T (current commit): 2.7s

largeDepsNft: 8.4s

⬇️ 15.57% decrease vs. a01ecdb

^  11.2s                                                                                                  
│   ┌──┐                                           10.7s                                                  
│   |  |   10.1s            10s             9.8s    ┌──┐                                    9.8s          
│   |  |    ┌──┐            ┌──┐            ┌──┐    |  |            9.5s                    ┌──┐          
│   |  |    |  |            |  |            |  |    |  |            ┌──┐                    |  |          
│ ──┼──┼────┼──┼────8.4s────┼──┼────────────┼──┼────┼──┼────────────┼──┼────8.5s────────────┼──┼────8.4s──
│   |  |    |  |    ┌──┐    |  |    7.6s    |  |    |  |    8.1s    |  |    ┌──┐            |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐    |  |    |  |    7.4s    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (9f3dab8): 10s
T-29 (bf7a4ac): 8.1s
T-28 (cc8ad7c): 11.9s
T-27 (58c8344): 11s
T-26 (9efef2f): 8.8s
T-25 (84ff0f8): 7.7s
T-24 (7eafe95): 7.6s
T-23 (57c38e3): 9.8s
T-22 (7898a4b): 10.7s
T-21 (d15abd9): 11.3s
T-20 (efa8ddc): 7.8s
T-19 (600dbf7): 10.4s
T-18 (6051e01): 9.4s
T-17 (57d30ec): 9.3s
T-16 (28b658a): 10.1s
T-15 (d7a0d50): 11.3s
T-14 (1618df8): 10.5s
T-13 (0297aa1): 8.3s
T-12 (3092e01): 11.2s
T-11 (cb23207): 10.1s
T-10 (070a7c9): 8.4s
T-9 (37bea38): 10s
T-8 (4b0f947): 7.6s
T-7 (a7b9972): 9.8s
T-6 (0381be5): 10.7s
T-5 (af0e46c): 8.1s
T-4 (b7fc082): 9.5s
T-3 (afaa4ef): 8.5s
T-2 (390820e): 7.4s
T-1 (a01ecdb): 9.8s
T (current commit): 8.4s

largeDepsZisi: 16.4s

⬇️ 21.78% decrease vs. a01ecdb

^  20.9s                                           21.1s                                                  
│   ┌──┐   19.9s           19.7s           20.1s    ┌──┐                                    20s           
│   |  |    ┌──┐            ┌──┐            ┌──┐    |  |           19.4s                    ┌──┐          
│   |  |    |  |            |  |            |  |    |  |            ┌──┐                    |  |          
│ ──┼──┼────┼──┼───16.5s────┼──┼────────────┼──┼────┼──┼────────────┼──┼────────────────────┼──┼───16.4s──
│   |  |    |  |    ┌──┐    |  |            |  |    |  |   16.1s    |  |   16.2s            |  |    ┌──┐  
│   |  |    |  |    |  |    |  |   15.1s    |  |    |  |    ┌──┐    |  |    ┌──┐   15.1s    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (9f3dab8): 20s
T-29 (bf7a4ac): 16s
T-28 (cc8ad7c): 23.4s
T-27 (58c8344): 20.7s
T-26 (9efef2f): 16.9s
T-25 (84ff0f8): 15.2s
T-24 (7eafe95): 15.2s
T-23 (57c38e3): 19.6s
T-22 (7898a4b): 21.5s
T-21 (d15abd9): 22.1s
T-20 (efa8ddc): 16s
T-19 (600dbf7): 20.6s
T-18 (6051e01): 18.8s
T-17 (57d30ec): 19.2s
T-16 (28b658a): 19.2s
T-15 (d7a0d50): 21.4s
T-14 (1618df8): 20.6s
T-13 (0297aa1): 16.3s
T-12 (3092e01): 20.9s
T-11 (cb23207): 19.9s
T-10 (070a7c9): 16.5s
T-9 (37bea38): 19.7s
T-8 (4b0f947): 15.1s
T-7 (a7b9972): 20.1s
T-6 (0381be5): 21.1s
T-5 (af0e46c): 16.1s
T-4 (b7fc082): 19.4s
T-3 (afaa4ef): 16.2s
T-2 (390820e): 15.1s
T-1 (a01ecdb): 20s
T (current commit): 16.4s

Skn0tt · 2023-11-02T16:47:07Z

Hmm, GitHub Actions seems to be having troubles 🤔

…-ship-it#1643) * fix: populate Netlify global before customer code * Update tests/v2api.test.ts Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> --------- Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

fix: populate Netlify global before customer code

cb461cd

Skn0tt requested a review from eduardoboucas November 2, 2023 16:32

Skn0tt self-assigned this Nov 2, 2023

Skn0tt requested a review from a team as a code owner November 2, 2023 16:32

eduardoboucas reviewed Nov 2, 2023

View reviewed changes

tests/v2api.test.ts Outdated Show resolved Hide resolved

Update tests/v2api.test.ts

e9b4fcc

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

eduardoboucas approved these changes Nov 2, 2023

View reviewed changes

Skn0tt enabled auto-merge (squash) November 2, 2023 16:35

Skn0tt merged commit 97992ee into main Nov 3, 2023

Skn0tt deleted the nf-global branch November 3, 2023 09:54

token-generator-app bot mentioned this pull request Nov 3, 2023

chore(main): release 9.26.0 #1645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: populate Netlify global before customer code #1643

fix: populate Netlify global before customer code #1643

Skn0tt commented Nov 2, 2023

github-actions bot commented Nov 2, 2023 •

edited

Loading

Skn0tt commented Nov 2, 2023

fix: populate Netlify global before customer code #1643

fix: populate Netlify global before customer code #1643

Conversation

Skn0tt commented Nov 2, 2023

github-actions bot commented Nov 2, 2023 • edited Loading

⏱ Benchmark results

largeDepsEsbuild: 2.7s

largeDepsNft: 8.4s

largeDepsZisi: 16.4s

Skn0tt commented Nov 2, 2023

github-actions bot commented Nov 2, 2023 •

edited

Loading