This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: detect alt version of remix handler #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 5ca965f largeDepsEsbuild: 1.4s⬆️ 0.16% increase vs. 5ca965f Legend
largeDepsNft: 5.6s⬆️ 2.33% increase vs. 5ca965f Legend
largeDepsZisi: 10.4s⬇️ 0.32% decrease vs. 5ca965f Legend
|
eduardoboucas
previously approved these changes
Nov 20, 2023
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
approved these changes
Nov 20, 2023
1 task
Skn0tt
added a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…1657) * fix: detect alt version of remix handler * chore: add another test for astro-style config Test case taken from netlify/zip-it-and-ship-it#1658. Co-Authored-By: @lilnasy * Update tests/unit/runtimes/node/in_source_config.test.ts Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com> --------- Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on our Remix template, I found that the handler function that was generated for me isn't detected as v2, even though it should. This PR adds a test case for it.
It also adds the most straight-forward fix I found. It has the downside of creating a false-positive (will comment below) about that, but I think that's OK. Ideally though, we find a solution that doesn't require changes to the existing tests.