This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: add support for feature flags #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
⏱ Benchmark resultsComparing with d5392a0 largeDepsEsbuild: 10.6s⬇️ 18.96% decrease vs. d5392a0 Legend
largeDepsZisi: 55.3s⬇️ 18.06% decrease vs. d5392a0 Legend
|
ehmicky
reviewed
Jul 4, 2021
| // List of supported flags and their default value. | ||
| const FLAGS = {} | ||
|
|
||
| const getFlags = (input = {}, flags = FLAGS) => |
There was a problem hiding this comment.
[sand] Would (input, flags = FLAGS) => ({ ...flags, ...input }) (or (input, flags = FLAGS) => ({ ...flags, ...removeFalsy(input) }) if input might contain undefined keys) be simpler?
One difference is that if input contains unknown flags, those would not be filtered, but that should not be a problem?
There was a problem hiding this comment.
I would actually like FLAGS to contain all the feature flags that ZISI is currently accepting, and make it so that any supplied flags that don't belong to that list are ignored (e.g. https://github.com/netlify/zip-it-and-ship-it/pull/567/files#diff-84cbdd132bc7ff6db27e194fa841b40864de4a8f661e0a79273ff9b2477e9e3dR11-R15). I think this is important to ensure that any flags used throughout the codebase are declared in one place for greater visibility.
There was a problem hiding this comment.
I'll merge this as is for now, but I'm happy to rework this later if you think we should.
ehmicky
approved these changes
Jul 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Unlike Netlify Build, zip-it-and-ship-it doesn't have an official feature flag mechanism. We've been using the functions configuration object to that effect, but that falls short in some situations.
For example, the config is only evaluated when a function is being processed, but we might want to have a feature flag that determines whether a function is even created or not, meaning the feature flag needs to come earlier in the process.
This PR adds a
featureFlagsproperty that is passed to bothzipFunctionandzipFunctionsand subsequently supplied togetFunctionsFromPaths.- Test plan
New tests added.
- A picture of a cute animal (not mandatory but encouraged)