Enable SwapAB only when the feature flag is set

netobserv · Feb 20, 2023 · 4e2d06f · 4e2d06f
1 parent 08c4bc5
commit 4e2d06f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/pipeline/extract/conntrack/conntrack.go b/pkg/pipeline/extract/conntrack/conntrack.go
@@ -76,7 +76,7 @@ func (ct *conntrackImpl) Extract(flowLogs []config.GenericMap) []config.GenericM
 				builder := NewConnBuilder(ct.metrics)
 				conn = builder.
 					Hash(computedHash).
-					ShouldSwapAB(ct.shouldSwapAB(fl)).
+					ShouldSwapAB(ct.config.TCPFlags.SwapAB && ct.shouldSwapAB(fl)).
 					KeysFrom(fl, ct.config.KeyDefinition, ct.endpointAFields, ct.endpointBFields).
 					Aggregators(ct.aggregators).
 					Build()

diff --git a/pkg/pipeline/extract/conntrack/conntrack_test.go b/pkg/pipeline/extract/conntrack/conntrack_test.go
@@ -1063,8 +1063,8 @@ func TestSwapAB(t *testing.T) {
 		defaultUpdateConnectionInterval, defaultEndConnectionTimeout)
 	tcpFlagsFieldName := "TCPFlags"
 	conf.Extract.ConnTrack.TCPFlags = api.ConnTrackTCPFlags{
-		FieldName:           tcpFlagsFieldName,
-		DetectEndConnection: true,
+		FieldName: tcpFlagsFieldName,
+		SwapAB:    true,
 	}
 	ct, err := NewConnectionTrack(opMetrics, *conf, clk)
 	require.NoError(t, err)