Build time optimization

[jotak]

FLP takes quite a long time to build and it seems like there could be some optimizations.

One thing that seems not optimal and taking quite some time is, for every code change, re-downloading/installing golangci-lint. As it's part of make build_code, it's in the same docker cache layer than code build, hence is retriggered for every code change. We should see how we could decouple them.

Other possible improvements to consider:

• check whether all dependencies we have are actually necessary
• add vendors in git?

[ronensc]

I found that this line is run before make build_code

flowlogs-pipeline/contrib/docker/Dockerfile

Line 12 in 0e670ba

RUN go mod download -modfile=.bingo/golangci-lint.mod

Doesn't it download golangci-lint?

[jotak]

Doesn't it download golangci-lint?

Despite this download, I often see the output stuck at that point:

(re)installing /app/bin/golangci-lint-v1.43.0

But maybe I am mislead by lacking output at different steps, it's possible that this "(re)installing golangci-lint" is actually finished but there's another hidden step behind .. like linting