Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build fails on fresh env #11

Open
yuvalk opened this issue Mar 25, 2024 · 2 comments
Open

make build fails on fresh env #11

yuvalk opened this issue Mar 25, 2024 · 2 comments

Comments

@yuvalk
Copy link

yuvalk commented Mar 25, 2024

GOFLAGS="" go install github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION}

this step fails on envs that doesnt have go.tmz.dev/musttag in their local cache

$ make build
which: no podman in (/home/yuval/.local/bin:/home/yuval/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin)
basename: missing operand
Try 'basename --help' for more information.
### Formatting code
go fmt ./...
### Test if prerequisites are met, and installing missing dependencies
GOFLAGS="" go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2
go: downloading go.tmz.dev/musttag v0.7.2
/home/yuval/go/pkg/mod/github.com/golangci/golangci-lint@v1.54.2/pkg/golinters/musttag.go:4:2: unrecognized import path "go.tmz.dev/musttag": parse https://go.tmz.dev/musttag?go-get=1: no go-import meta tags ()
make: *** [Makefile:73: prereqs] Error 1

I'm using

$ go version
go version go1.21.8 linux/amd64

on a new vm (so nothing in my caches yet)

Copy link

Congratulations for contributing your first netobserv-cli issue

@jotak
Copy link
Member

jotak commented Mar 26, 2024

Trying to reproduce, cleaning up & removing my "~/go/pkg/mod/github.com/golangci" and "go/pkg/mod/go.tmz.dev", but it worked for me, everything seem downloaded again as expected (I tried with go 1.21.7)
Also on CI (which also starts with a fresh new env) this is working, example: https://github.com/netobserv/network-observability-cli/actions/runs/8433720228/job/23095366225#step:5:8

Can you post your go env so we can check if something differs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants