[#60][#62] Unchecked Exception in Parser #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update maven plugin and contact information to match master pom.xml
Modified test to use Junit4's `Parameterized` runner and added an emoji test
UrielCh
approved these changes
Apr 24, 2021
|
Looks good, except that you include PR74, this PR in not published in any V2.4 version yet. |
|
PR74 should not be included in branch 2.3; it could cause breathing changes for current users; the parser is now based on OS environment default encoding. Maybe I'm wrong. Furthermore, what is your point of view about issue 36? As you may have noticed, I'm not using java anymore... |
This reverts commit 306617d.
|
I reverted the fix for #73 as this might introduce a breaking change. |
|
@UrielCh would you mind to have a second look and merge this PR? I was hoping to see the fixed version in the next spring-boot update... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberFormatExceptioninJSONParserBase(Fixes Uncaught Exception in Parser #60 , when we release new version to fix CVE-2021-27568 #62)