Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Route::*_KEY constants public #226

Open
jiripudil opened this issue Aug 6, 2019 · 1 comment
Open

Make Route::*_KEY constants public #226

jiripudil opened this issue Aug 6, 2019 · 1 comment

Comments

@jiripudil
Copy link

Hello, I am wondering why the Route::MODULE_KEY and Route::PRESENTER_KEY constants are private and whether they could be made public? We were using them in route definitions prior to 3.0, and now we have to replace them with 'module' and 'presenter' "magic" strings which seems like a step back.

Thanks for your consideration!

@dg
Copy link
Member

dg commented Aug 7, 2019

Because it uses them internally. You might even need constant ACTION_KEY, which Route doesn't even have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants