Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issue with Row vs IRow #291

Open
MartinMystikJonas opened this issue Jul 20, 2022 · 1 comment
Open

Compatibility issue with Row vs IRow #291

MartinMystikJonas opened this issue Jul 20, 2022 · 1 comment

Comments

@MartinMystikJonas
Copy link
Contributor

MartinMystikJonas commented Jul 20, 2022 •
edited
Loading

Version: 3.1.5

Bug Description

Compatibility of IRow and Row is causing confusion of static analysers even when compatibility files are processed

... expects Nette\Database\Row, Nette\Database\Table\ActiveRow given

Expected Behavior

IRow and Row should be treaded as aliases

Possible Solution

compatibility files should define all renamed interfaces as aliases
@MartinMystikJonas
Copy link
Contributor Author

MartinMystikJonas commented Jul 20, 2022 •
edited
Loading

I am bit confused now. IRow is marked as deprecated and hints we should use Row instead. But Row is a class. And ActiveRow does not extend Row but implements deprecated IRow. So static analysis either complains about use of deprecated IRow (and suggest replacing it with Row) or Row is used and type hierarchy breaks.

What is recommended solution here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinMystikJonas