Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pre-shared keys #246

Open
thomdev opened this issue Apr 6, 2021 · 8 comments
Open

Add support for pre-shared keys #246

thomdev opened this issue Apr 6, 2021 · 8 comments
Milestone

Comments

@thomdev
Copy link
Contributor

thomdev commented Apr 6, 2021

Client and server should have the option to use out-of-band pre-shared keys rather than certificates.

https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#Pre-shared-keys

@normanmaurer normanmaurer added this to the 0.0.11.Final milestone Apr 6, 2021
@normanmaurer
Copy link
Member

Yes! I will add support for it.

@normanmaurer
Copy link
Member

As it turns out this is only for TLS1.2 and so not what we need... currently investigating how to add support for TLS1.3 which is used for QUIC.

@normanmaurer
Copy link
Member

We may need to wait for BoringSSL to add support /cc @davidben

@normanmaurer
Copy link
Member

@davidben is this something you support yet ? It's not clear to me atm

@davidben
Copy link

davidben commented Jun 3, 2023

We don't currently support it in TLS 1.3. The problem is the original TLS 1.3 PSK mechanism was, IMO, defined wrong. It does this hash-matching thing, but that ties together your PSK configuration (managed by the caller), and TLS parameter selection (in many cases, library behavior).

Imported PSKs resolves this. My motivation there was, in fact, "someone is going to want PSKs someday and I want this specified before I need to implement it". 😄 But all the folks who wanted PSKs have since fizzled, so we never ended up implementing it. It's just sitting there as the plan of record, should we ever want to add it.

@normanmaurer
Copy link
Member

@davidben got it... So I guess there is not much we can do here really.

@aozmen121
Copy link

aozmen121 commented Oct 30, 2023

@davidben & @normanmaurer Any Updates on PSKs being supported by Netty? We currently have requirements to handle PSK with TLS 1.2 min.

@aozmen121
Copy link

@davidben Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants