Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rustc d7e1bb5ff 2014-09-21 01:00:29 +0000 #11

Merged
merged 1 commit into from
Sep 22, 2014

Conversation

tomaka
Copy link
Collaborator

@tomaka tomaka commented Sep 21, 2014

No description provided.

@brendanzab
Copy link
Collaborator

This has broken gl-rs - it would be great if this could be merged as soon as possible!

brendanzab added a commit to brendanzab/gl-rs that referenced this pull request Sep 21, 2014
brendanzab added a commit to brendanzab/gl-rs that referenced this pull request Sep 21, 2014
Temporarily switch to tomaka/rust-xml until netvl/xml-rs#11 is merged
@netvl
Copy link
Owner

netvl commented Sep 21, 2014

Thanks! What does this fix? I mean, why it is not possible to use common::Error directly as enum value field?

@tomaka
Copy link
Collaborator Author

tomaka commented Sep 21, 2014

It's because of rust-lang/rust#17338
The Error variant in XmlEvent now conflicts with the common::Error that you are importing.

(note that I don't understand the message in the PR, I just know that enum variants now conflict with everything else)

@netvl
Copy link
Owner

netvl commented Sep 22, 2014

Ah, that change finally have landed. Ok, thank you very much!

netvl added a commit that referenced this pull request Sep 22, 2014
Update to rustc d7e1bb5ff 2014-09-21 01:00:29 +0000
@netvl netvl merged commit 62661b9 into netvl:master Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants