Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making getValidators method public on JsonSchema class. #269

Closed
prashanthjos opened this issue Mar 11, 2020 · 4 comments
Closed

Making getValidators method public on JsonSchema class. #269

prashanthjos opened this issue Mar 11, 2020 · 4 comments

Comments

@prashanthjos
Copy link
Member

We wanted to make getValidators method public on JsonSchema.java. We have a use case where we want to get all RefValidators for given JSON Schema and run through them to write our Own custom logic.
@stevehu
Copy link
Contributor

stevehu commented Mar 11, 2020

I don't think there is an issue to expose the method. Please make the change in the same PR. Thanks.

@prashanthjos
Copy link
Member Author

Sure. Also I see the newSchema method is private in JsonSchemaFactory. It would be helpful if this method is protected so that we can create our own subclasses of JsonSchema class and override or add our own behaviour.

@prashanthjos
Copy link
Member Author

@stevehu PR is updated with changes.

@stevehu
Copy link
Contributor

stevehu commented Mar 12, 2020

Resolved in this PR #268

@stevehu stevehu closed this as completed Mar 12, 2020
@justin-tay justin-tay mentioned this issue Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @prashanthjos