New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When stopping the server, give 30 seconds grace period to let service discovery propagate to all clients #20

Closed

stevehu opened this issue Feb 2, 2017 · 1 comment

Assignees

Labels

Contributor

stevehu commented Feb 2, 2017

It takes a few seconds for failed service to be removed from client discovery cache. The shut down sequence should be:

un-register from consul registry
still handling requests for 30 seconds
shut down

stevehu added the enhancement label

stevehu self-assigned this

Contributor Author

stevehu commented Aug 11, 2018

This has been implemented in #213

stevehu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment