Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end DNS integration: Make cmd-nse-icmp-responder DNS configurable #133

Closed
denis-tingaikin opened this issue Apr 12, 2021 · 0 comments · Fixed by #158
Closed

End to end DNS integration: Make cmd-nse-icmp-responder DNS configurable #133

denis-tingaikin opened this issue Apr 12, 2021 · 0 comments · Fixed by #158
Assignees
@denis-tingaikin
Labels
enhancement New feature or request

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 12, 2021 •
edited
Loading

Related to

networkservicemesh/sdk#825

Description

We need to add a possible pass DNS contexts via env to cmd-nse-icmp-responder

Implementation details

  1. Add new field into env config for https://github.com/networkservicemesh/api/blob/master/pkg/api/networkservice/connectioncontext.pb.go#L434
  2. If SearchDomains are passed add dnscontext/server into server chain as additionalFunctionallity.

Estimation

2h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-tingaikin denis-tingaikin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@denis-tingaikin