From 465077a597419cfc9408fd5029d8022375f9abf4 Mon Sep 17 00:00:00 2001 From: Nikita Skrynnik <93182827+NikitaSkrynnik@users.noreply.github.com> Date: Mon, 19 Dec 2022 23:52:40 +1100 Subject: [PATCH] [qfix] Add return statement in getSpiffeIDFromPath func (#1402) * [qfix] add return statement in getSpiffeIDFromPath Signed-off-by: Nikita Skrynnik * use Warnf Signed-off-by: Nikita Skrynnik Signed-off-by: Nikita Skrynnik --- pkg/registry/common/authorize/common.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/registry/common/authorize/common.go b/pkg/registry/common/authorize/common.go index 3d69b42b8..e9e96530e 100644 --- a/pkg/registry/common/authorize/common.go +++ b/pkg/registry/common/authorize/common.go @@ -75,6 +75,7 @@ func getRawMap(m *PathIdsMap) map[string][]string { func getSpiffeIDFromPath(ctx context.Context, path *grpcmetadata.Path) spiffeid.ID { if len(path.PathSegments) == 0 { log.FromContext(ctx).Warn("can't get spiffe id from empty path") + return spiffeid.ID{} } tokenString := path.PathSegments[0].Token @@ -98,7 +99,7 @@ func getSpiffeIDFromPath(ctx context.Context, path *grpcmetadata.Path) spiffeid. id, err := spiffeid.FromString(subString) if err != nil { - log.FromContext(ctx).Warn("failed to parse spiffeid from string: %s", err.Error()) + log.FromContext(ctx).Warnf("failed to parse spiffeid from string: %s", err.Error()) return spiffeid.ID{} } return id