Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude-prefixes not updated correctly #1179

Closed
Mixaster995 opened this issue Nov 29, 2021 · 1 comment · Fixed by #1180
Closed

Exclude-prefixes not updated correctly #1179

Mixaster995 opened this issue Nov 29, 2021 · 1 comment · Fixed by #1180
Assignees

Comments

@Mixaster995
Copy link
Contributor

Mixaster995 commented Nov 29, 2021

Expected Behavior

Excluded-prefixes should exactly match prefixes from source file.

Current Behavior

Excluded-prefixes only appended never removed

Scenario

  1. Initial request starts
  2. Excluded prefixes server reads prefixes from file and appending it to request's excluded prefixes
  3. After initial request refresh mechanism uses the same request object(with already added excluded prefixes)
  4. Excluded prefixes server reads prefixes from file(which might be modified at this moment) and if it's different set of prefixes than on initial request just appends it to request.
  5. Every refresh it repeats, so if file with excluded prefixes changes often, it'll just grow excluded prefixes

Possible solution

Add client chain element, and on request it's going to save excluded prefixes added to request by client, and on request response change possibly modified request prefixes back to saved ones.
Also, update client's cmd-s to use this chain element

@Mixaster995
Copy link
Contributor Author

@edwarnicke could you, please, take a look to see if you okay with suggested solution
It prepared it in #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant