-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMage 20.4.0 / PHP 8.2.19 compatibility #1424
Comments
@aminemekkidph2m The actual stable version of n98-magerun does not support PHP 8.2. |
@aminemekkidph2m please test unreleased v3.0 and let us know if the error is still there. I'll fix it in time. (The linked PR is the "next step" that removes some outdated code.) |
@cmuench can you please check why the build failed for v3? |
Tested some commands with v3 and php8.2 ... no errors. |
@sreichel i was able to reproduce the issue in my ddev environment. I will try to fix it. |
@sreichel A rebuild of the phar file fixed the download test job. |
@sreichel I added OpenMage 20.1.0 and 20.9.0 to the Github Actions. |
@cmuench i will test it later. Sounds similar to OpenMage/magento-lts#2961 Edit: in 20.1.0 lib/Zend was replaced with composer dependency. |
@sreichel it's strange. We install via composer. It seems that the dependency is loaded correctly. |
@cmuench yeah, actions log seems okay. Local ddev works too. Is it possible that vendor is outside of installDir "magento"? Possible related: OpenMage/magento-lts#3226 I have no other idea so far and try to debug with https://nektosact.com |
@sreichel I just allowed the Github Actions jobs running phpunit and bats to fail by setting |
@cmuench provided a first fix over there. Note: maybe we have to add some lines to clean EAV-cache. But lets wait with this. |
@aminemekkidph2m can we close it? |
Closed for no response. v3-dev works with php8.x. |
Describe the bug
It looks like current version is not compatible with PHP 8.2 version.
Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in phar:///usr/local/bin/magerun/vendor/symfony/yaml/Inline.php on line 49
Expected behaviour
Output not returning errors.
Steps to reproduce the issue
Running any command using PHP>8.2 version.
I'm currently using OpenMage version of Magento.
Technical details
The text was updated successfully, but these errors were encountered: