Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to have alternate format when running individual features #11

Merged
merged 3 commits into from
Jun 10, 2011

Conversation

NickClark
Copy link
Contributor

There should be a way to dictate a different format when not running all features. This pull request implements this by adding a new option called failure_format.

When set, running individual features will use this format instead. This is done by inspecting the cli string for a format that does not have an associated --out option and changes the argument.

@netzpirat
Copy link
Owner

This is a very interesting feature and supports my beliefe that all configuration should go into the :cli option and not into a Cucumber profile.

I find the name failure_format misleading, because it's used for everything except when running all features and thus not only for failures. To stick with the Guard jargon, change_format would be more precise. But a real failure_format, that is used whenever a failed feature is added to the run, would also be a worthy feature :P

I'm very busy over the weekend and I won't have access to a computer until Tuesday, but I'll have a look at this then again.

Thank you very much and have a nice weekend!

@NickClark
Copy link
Contributor Author

I was struggling over the name as well. I agree that change_format would be better. I'll update it.

Having a true failure_format might be cool, but perhaps not as utilized; unless, that is, someone comes up with a cool new cucumber formatter that, perhaps, weeds out everything except the failing scenarios, instead of showing the entire feature containing the failure.

netzpirat added a commit that referenced this pull request Jun 10, 2011
Add option to have alternate format when running individual features
@netzpirat netzpirat merged commit 58ddf4a into netzpirat:master Jun 10, 2011
@NickClark
Copy link
Contributor Author

Thanks! And I thought you were going to be busy all weekend. :)

@netzpirat
Copy link
Owner

Just from tomorrow morning until Monday, but not tonight!

hron pushed a commit to hron/guard-cucumber that referenced this pull request Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants