Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect binstubs option #31

Merged
merged 1 commit into from
Jan 17, 2012
Merged

Respect binstubs option #31

merged 1 commit into from
Jan 17, 2012

Conversation

dnagir
Copy link
Contributor

@dnagir dnagir commented Jan 17, 2012

I realised :binstubs is not supported at all even though it is presented in the README.

This PR should close #30.

Sorry, no specs here.

netzpirat added a commit that referenced this pull request Jan 17, 2012
Respect binstubs option
@netzpirat netzpirat merged commit 8c6429a into netzpirat:master Jan 17, 2012
netzpirat added a commit that referenced this pull request Jan 17, 2012
This reverts commit 8c6429a, reversing
changes made to 330c90a.
@netzpirat
Copy link
Owner

Thanks for this, although I had to revert the merge, because there was already a pull request that added the binstubs option including specs and README update. That you didn't see it was my fault, I somehow removed it when updating the development dependencies and didn't realize it.

The repo is now clean again and a new version 0.7.5 has been released with binstubs support.

@dnagir
Copy link
Contributor Author

dnagir commented Jan 17, 2012

Awesome! Thanks a lot.
On Jan 17, 2012 7:20 PM, "Michael Kessler" <
reply@reply.github.com>
wrote:

Thanks for this, although I had to revert the merge, because there was
already a pull request that added the
binstub options including specs and README update. That you didn't see it
was my fault, I somehow removed it
when updating the development dependencies and didn't realize it.

The repo is now clean again and a new version 0.7.5 has been released with
binstubs support.


Reply to this email directly or view it on GitHub:
#31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binstubs option seems to be ignored
2 participants