Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use any formatter together with the formatter for notifications. #5

Merged
merged 1 commit into from
Mar 28, 2011

Conversation

hron
Copy link
Contributor

@hron hron commented Mar 26, 2011

Please, consider to merge this changes. I've slightly changed how guard-cucumber pass custom formatter to cucumber to allow use any formatter and have guard's notifications.

The main trick was in passing --formatter CucumberFormatter --out /dev/null. In this case cucumber allow specify additional formatters like --format pretty or --format progress.

Thank you!

… /dev/null

output to allow use other than 'progress' formatter when use guard-cucumber.
@netzpirat netzpirat merged commit 78cd0af into netzpirat:master Mar 28, 2011
@netzpirat
Copy link
Owner

Thank you very much for this pull request!! This is a huge step forward to make Guard::Cucumber more configurable to the users need by not forcing a specific formatter.

I just made a little change, so that /dev/null is NIL on MS windows systems (I usually don't care about windows, but the change was to easy to ignore). In addition a new configuration option has been introduced: with :notification => false the whole Guard::Cucumber formatter will be skipped and leads to a bare call of the Cucumber command. Together with the :cli option, the user can now fully configure Guard::Cucumber to his need.

netzpirat added a commit that referenced this pull request Dec 4, 2012
Fix contributors link in README
hron pushed a commit to hron/guard-cucumber that referenced this pull request Nov 10, 2015
---

Please, consider to merge this changes. Ive slightly changed how guard-cucumber pass custom formatter to cucumber to allow use any formatter and have guards notifications.

The main trick was in passing --formatter CucumberFormatter --out /dev/null. In this case cucumber allow specify additional formatters like --format pretty or --format progress.

Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants