Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of spec directory path and rake task #42

Closed
ebryn opened this issue Mar 7, 2012 · 5 comments
Closed

Allow configuration of spec directory path and rake task #42

ebryn opened this issue Mar 7, 2012 · 5 comments

Comments

@ebryn
Copy link

ebryn commented Mar 7, 2012

spec/javascripts and rake jasmine are both hardcoded. Would be great if that was configurable.

@netzpirat
Copy link
Contributor

I've added a :spec_dir option to customize the Jasmine spec directory and the :server option will make Guard::Jasmine execute a Rake task in a child process with the same name as specified in the :server option, when the server strategy is unknown. There is some more info in the README.

The changes are in master and I'll release a new version asap I got some good feedback :P

@ebryn
Copy link
Author

ebryn commented Mar 7, 2012

Wow, that was fast! :D

I was able to remove our monkeypatches and it's working great. Is there a reason why your default jasmine_url includes /jasmine?

@netzpirat
Copy link
Contributor

I developed Guard::Jasmine initially for Rails 3.1 and Jasminerice, which serves the Jasmine spec runner under /jasmine. Rails 2 & 3 support was added later when I refactored the server start and to be honest, it has been coded solely against the specs and I haven't tried it once by myself on a real project (but some issues were reported, so I assume some people are using it).

What's your setup? If the official Jasmine gem serves the spec runner under another URL, I could easily make the default spec URL different for this server type.

@ebryn
Copy link
Author

ebryn commented Mar 7, 2012

I believe by default the Jasmine gem serves at /.

I've got a custom spec dir & rake task, but I believe everything else is default.

@netzpirat
Copy link
Contributor

I've released 0.9.14 that contains the :spec_dir option and the :server enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants