Add --coverage_html support to cli #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable running $ guard-jasmine --coverage_html to generate the html coverage report.
|
...and I quickly realized that I wanted coverage summary as well. Added that to this request likewise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm missing something (I'm new to guard-jasmine), there was no way to get html coverage when running shell-level guard-jasmine outside of guard. So I added --coverage_html to the CLI options, and passed it along.
The only extra liberty I took is to have --coverage_html imply --coverage. Seems reasonable to me that
$ guard-jasmine --coverage_html
should work, rather than needing
$ guard-jasmine --coverage --coverage_html
Thanks much for putting all this together!