Bug fix: coverage hangs for large files #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that used IO.pipe & ChildProcess to run istanbul was waiting for the process to finish before reading the result. With a file whose instrumentation is large enough to exceed the system IO buffer size, the istanbul process would block and we'd have deadlock. Rather than fixing that using the appropriate nonblocking reading, just switched to %x[]
|
Thanks a lot for all your pull requests! Stuff like this make me enjoy open source. Release 1.12.2. |
|
Glad I could contribute! Thanks for the quick turnaround. ...And stuff like guard-jasmine makes me enjoy open source :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that used IO.pipe & ChildProcess to run istanbul was waiting for the process to finish before reading the result. With a file whose instrumentation is large enough to exceed the system IO buffer size, the istanbul process would block and we'd have deadlock.
Rather than fixing that using the appropriate nonblocking reading, just switched to %x[]