Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to customize guard-jasmine's server mount point #134

Merged
merged 2 commits into from
Jun 26, 2013

Conversation

adamstrickland
Copy link
Contributor

I wanted to be able to use guard-jasmine in conjunction with jasmine-rails (rather than jasminerice), so needed to be able to set the mount point/path for the jasmine runner url. Added :server_mount option, which defaults to '/jasmine'

@netzpirat netzpirat merged commit ebe5a51 into guard:master Jun 26, 2013
@netzpirat
Copy link
Contributor

That's very interesting. Do you have any experience how it compares to Jasminerice? Would it be worth to add some words about it to the README? Two minor things came to mind and I'd happily release a new patch version that addresses:

  • Auto-detection of the :server_mount option. Something like defined?(JasmineRails) ? '/specs' : '/jasmine'
  • Add support for the command line runner by adding the option also to cli.rb

Thanks a lot!

@adamstrickland
Copy link
Contributor Author

Yes and no. Up until yesterday, we were using jasminerice. The whole setup (jasmine, jasmine-rails, jasminerice, jasmine-headless-webkit, guard-jasmine) was put together by someone else about a year ago. Although it usually worked on our local dev machines, it was much more problematic when running under CI. We recently moved to CircleCI, and found that that jasmine setup would not run (at least, not as-is) in that environment. So I took a look, stripping it all down and starting with a clean setup. Our needs: we're using the asset pipeline, so that needed to be handled; it should work in both a CI environment and a local dev machine; it should work with guard. The cleanest solution for the first two needs was simply jasmine-gem (1.3.1) and jasmine-rails (0.4.5), following the jasmine-rails setup, which adds a '/specs' mount point in routes.rb, hence the server_mount option.

So in short, I don't have much of a comparison, per se, but I found that for us, jasmine-rails was a simpler setup, and that was preferred.

I'd be happy to add some words about it in the README, as well as the other 2 points below, probably in the next couple of days.

a

adam strickland : adam.strickland@gmail.com : 214.906.3350

On 26-Jun-2013, at 18:17 , Michael Kessler notifications@github.com wrote:

That's very interesting. Do you have any experience how it compares to Jasminerice? Would it be worth to add some words about it to the README? Two minor things came to mind and I'd happily release a new patch version that addresses:

Auto-detection of the :server_mount option. Something like defined?(JasmineRails) ? '/specs' : '/jasmine'
Add support for the command line runner by adding the option also to cli.rb
Thanks a lot!


Reply to this email directly or view it on GitHub.

@netzpirat
Copy link
Contributor

Thanks for the info. I think I'm gonna give jasmine-rails also a try after my holidays in August. Did you move to CircleCI from Travis CI? I'm just asking because the slow IO on Travis is a pain for larger projects.

@adamstrickland
Copy link
Contributor Author

Travis CI is actually probably the only one we haven't tried… We moved to CircleCI from Tddium, altho we also kicked the tires at Semaphore and Codeship.

I do like Circle; it's fairly fast, and has the option of greater parallelization should we need it. Tddium has some nice features (auto-screen shot for every failed test), but we moved away due to the fact that we had a hard time getting consistent results using their service. Also, CircleCI provides a way to SSH into the Xvfb instance, even running the tests over X11 to my desktop if so desired; pretty nice for debugging.

a

adam strickland : adam.strickland@gmail.com : 214.906.3350

On 27-Jun-2013, at 10:47 , Michael Kessler notifications@github.com wrote:

Thanks for the info. I think I'm gonna give jasmine-rails also a try after my holidays in August. Did you move to CircleCI from Travis CI? I'm just asking because the slow IO on Travis is a pain for larger projects.


Reply to this email directly or view it on GitHub.

@netzpirat
Copy link
Contributor

Sound awesome. Also something to add to my todo list :)

@rymai
Copy link
Member

rymai commented Jun 27, 2013

I just want to 👍 for CircleCI, we're using it (after Semaphore too) for all our private repos and are very happy with it so far (except for the fact that they badges not consistent with the other awesome badges, i.e. screen shot 2013-06-27 at 18 32 42 :P)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants